Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rflink with tests #1204

Open
wants to merge 310 commits into
base: master
Choose a base branch
from
Open

Rflink with tests #1204

wants to merge 310 commits into from

Conversation

ngeissel
Copy link
Member

@ngeissel ngeissel commented May 26, 2021 •
edited
Loading

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)
  • If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
  • If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
  • If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.
  • Did you add fake requests data for the demo mode (front/src/config/demo.json) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Please provide a description of the change here. It's always best with screenshots, so don't hesitate to add some!

mTondenier and others added 30 commits March 21, 2020 12:32
@mTondenier
const upd
6cd6d35
@mTondenier
mdoels up
2f50bd5
@mTondenier
migrations upd
54c7cda
@mTondenier
api upd
a7d7ecd
@mTondenier
seeders upd
c7905a5
@mTondenier
Add files via upload
524fefb
@mTondenier
Add files via upload
f18dc24
@mTondenier
Add files via upload
869856f
@mTondenier
scene lib update fix
beb5073
@mTondenier
tests fixes
0a5316c
@mTondenier @mathistdn
create a device when a message is received
a497f01
@mTondenier @mathistdn
fix controllers object is undefined
f69959e
@mathistdn
rebase
1e0c023
@mathistdn
new commit for rebase
b8947f7
@mTondenier @mathistdn
prettier
8a44a6a
@mathistdn
Merge branch 'rflink' of https://github.com/mTondenier/Gladys into rf…
3b701d6 
…link
@mathistdn
prettier
800b6b7
@mathistdn
eslint
99c63d8
@mathistdn
prettier
7102c6a
@mTondenier
Add files via upload
cbb0bbc
@mTondenier
Add files via upload
a5cff15
@mathistdn
Update constants.js
693969e
@mathistdn
Merge branch 'rflink' of https://github.com/mTondenier/Gladys into rf…
6ec3e0b 
…link
@mathistdn
Revert "Merge branch 'rflink' of https://github.com/mTondenier/Gladys …
2fd9b6d 
…into rflink"

This reverts commit 6ec3e0b, reversing
changes made to 693969e.
@mathistdn
add multiples logger.log
aa84c7b
@mathistdn
Read only check box
d8327ba
@mathistdn
prettier and console remove
379edb7
@mathistdn
Devices filtering
4de0bde
@mathistdn
bug fix
3c53e21
@mathistdn
bug fixes
860b9f4
@stale stale bot removed the stale label Aug 25, 2023
@relativeci
Copy link

relativeci bot commented Sep 13, 2023 •
edited
Loading

#2841 Bundle Size — 10.46MiB (+1.98%).

5b500fa(current) vs 216f637 master#2828(baseline)

Warning

Bundle contains 3 duplicate packages – View duplicate packages

Bundle metrics  Change 6 changes Regression 2 regressions
                 Current
#2841		      Baseline
#2828
Regression  Initial JS 5.65MiB(+1.64%) 5.55MiB
Regression  Initial CSS 304.7KiB(~+0.01%) 304.68KiB
Change  Cache Invalidation 60.76% 0%
No change  Chunks 51 51
Change  Assets 172(+0.58%) 171
Change  Modules 1509(+0.94%) 1495
No change  Duplicate Modules 21 21
Change  Duplicate Code 0.83%(-1.19%) 0.84%
No change  Packages 124 124
No change  Duplicate Packages 3 3
Bundle size by type  Change 4 changes Regression 4 regressions
                 Current
#2841		      Baseline
#2828
Regression  JS 7.44MiB (+1.28%) 7.34MiB
Regression  IMG 2.58MiB (+4.38%) 2.48MiB
Regression  CSS 321.48KiB (~+0.01%) 321.47KiB
No change  Fonts 93.55KiB 93.55KiB
Regression  Other 17.7KiB (+0.45%) 17.62KiB
No change  HTML 13.58KiB 13.58KiB

Bundle analysis report Branch ngeissel:rflink Project dashboard

Generated by RelativeCI Documentation Report issue

@stale Stale
Copy link

stale bot commented Oct 28, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Oct 28, 2024
@stale stale bot removed the stale label Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pierre-Gilles Pierre-Gilles Pierre-Gilles left review comments

@atrovato atrovato atrovato requested changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Service Development
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ngeissel @Pierre-Gilles @atrovato @VonOx @mTondenier @mathistdn